Sandro Bonazzola has posted comments on this change.
Change subject: network: firewalld: fixed firewall-cmd support
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 81: state=False,
Line 82: )
Line 83: version_tuple = tuple([int(x) for x in stdout[0].split('.')])
Line 84: version = '%02x%02x%02x' % version_tuple
Line 85: return int(version, 16)
For avoiding unexpected version numbering issue. The second approach will
accept both 0.1.0 and 0.0.1.0 and translate it to the same integer version 256.
the first approach will raise an exception in 0.0.1.0 case but avoid to let us
think everything is ok when it is not ok.
Line 86:
Line 87: def _get_active_zones(self):
Line 88: rc, stdout, stderr = self.execute(
Line 89: (
--
To view, visit http://gerrit.ovirt.org/16094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
