Sandro Bonazzola has posted comments on this change. Change subject: network: firewalld: fixed firewall-cmd support ......................................................................
Patch Set 4: Verified (1 inline comment) .................................................... File src/plugins/otopi/network/firewalld.py Line 42: Line 43: """ Line 44: Line 45: FIREWALLD_SERVICES_DIR = '/etc/firewalld/services' Line 46: _ZONE_RE = re.compile(r'^\w+$') dropped ':', not present in the output Line 47: _INTERFACE_RE = re.compile( Line 48: flags=re.VERBOSE, Line 49: pattern=r""" Line 50: \s+ -- To view, visit http://gerrit.ovirt.org/16094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1 Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
