Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: support firewall-cmd >= 0.3
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 71: ret = ''.join(stdout).find('--permanent') != -1
Line 72: return ret
Line 73:
Line 74: def _get_firewalld_cmd_version(self):
Line 75: rc, stdout, stderr = self.execute(
please make sure this command is working when firewalld is down, for me it does
not. in this case check if service is down, if it is start execute and stop.
Line 76: (
Line 77: self.command.get('firewall-cmd'),
Line 78: '--version',
Line 79: ),
--
To view, visit http://gerrit.ovirt.org/16094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
