Liron Ar has posted comments on this change. Change subject: core: adding OvfHelper ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java Line 22: VM vm = new VM(); Line 23: ArrayList<DiskImage> diskImages = new ArrayList<DiskImage>(); Line 24: ArrayList<VmNetworkInterface> interfaces = new ArrayList<VmNetworkInterface>(); Line 25: ovfManager.ImportVm(ovf, vm, diskImages, interfaces); Line 26: Roy, i'm not sure that i fully agree with moving those two lines to the ovf manager. as i see it, ovf manager is a class who has solely purpose - to parse an ovf into objects - how to assemble a "valid" vm objects from this object - if the bll layer responsibility - as we can't transfer all the logic to the util layer, i think that generally we should leave all the logic that is beyond parsing the ovf to the bll layer calls. anyway, regardless - i will do further refoctor to this method and i'll look into changing the current relation between those classes as you suggested. Line 27: // add images Line 28: vm.setImages(diskImages); Line 29: // add interfaces Line 30: vm.setInterfaces(interfaces); -- To view, visit http://gerrit.ovirt.org/15626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
