Ravi Nori has posted comments on this change.

Change subject: 1. core: Add createAction and runAction(commandBase) methods
......................................................................


Patch Set 8: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 322:     protected VdcReturnValueBase runAction(CommandBase<?> command,
Line 323:             boolean runAsInternal,
Line 324:             CommandContext context) {
Line 325:         VdcReturnValueBase returnValue =
Line 326:                 evaluateCorrelationId(command);
fixed
Line 327:         if (returnValue != null) {
Line 328:             return returnValue;
Line 329:         }
Line 330:         command.setInternalExecution(runAsInternal);


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
Line 82:     ArrayList<VdcReturnValueBase> 
runInternalMultipleActions(VdcActionType actionType,
Line 83:             ArrayList<VdcActionParametersBase> parameters,
Line 84:             ExecutionContext executionContext);
Line 85: 
Line 86: 
fixed


-- 
To view, visit http://gerrit.ovirt.org/15795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c420aba7a95ec7264dad31a6bca9d11edf3a607
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to