Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: logical network editor
......................................................................
Patch Set 5: (6 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/network/LogicalNetworkEditor.ui.xml
Line 4: xmlns:g="urn:import:com.google.gwt.user.client.ui"
Line 5: xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor">
Line 6:
Line 7: <ui:style>
Line 8: .mainPanel {
probably should be removed for now as it's unsed
Line 9: }
Line 10: </ui:style>
Line 11:
Line 12: <g:FlowPanel addStyleNames="{style.mainPanel}">
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 1019: @Override
Line 1020: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 1021: PropertyChangedEventArgs e =
(PropertyChangedEventArgs) args;
Line 1022: if (e.PropertyName == "nicWithLogicalNetworks") {
//$NON-NLS-1$
Line 1023:
logicalNetworksEditor.setValue(object.getNicWithLogicalNetworks());
isn't it being already set on edit
Line 1024: }
Line 1025: }
Line 1026:
Line 1027: });
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 1071: Frontend.RunAction(VdcActionType.AddVmFromScratch,
parameters,
Line 1072: new IFrontendActionAsyncCallback() {
Line 1073: @Override
Line 1074: public void
executed(FrontendActionAsyncResult result) {
Line 1075: VdcReturnValueBase returnValueBase =
result.getReturnValue();
code seems almost similar in most callbacks, not sure, but can it be
extracted/reused without looking too 'forced'?
Line 1076: if (returnValueBase != null &&
returnValueBase.getSucceeded()) {
Line 1077: final Guid createdVmId = (Guid)
returnValueBase.getActionReturnValue();
Line 1078:
defaultNetworkCreatingManager.createNetworks(createdVmId,
Line 1079:
model.getNicWithLogicalNetworks());
Line 1108: param.setSoundDeviceEnabled((Boolean)
unitVmModel.getIsSoundcardEnabled().getEntity());
Line 1109:
Frontend.RunAction(VdcActionType.AddVmFromTemplate, param,
Line 1110: new
IFrontendActionAsyncCallback() {
Line 1111: @Override
Line 1112: public void
executed(FrontendActionAsyncResult result) {
same
Line 1113: if
(result.getReturnValue().getSucceeded()) {
Line 1114:
defaultNetworkCreatingManager.createOrUpdateNetworks((Guid)
result.getReturnValue()
Line 1115:
.getActionReturnValue(),
Line 1116:
unitVmModel.getNicWithLogicalNetworks());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NicWithLogicalNetworks.java
Line 7:
Line 8: private VmNetworkInterface networkInterface;
Line 9:
Line 10: public NicWithLogicalNetworks(VmNetworkInterface networkInterface)
{
Line 11: super();
redundant
Line 12: this.networkInterface = networkInterface;
Line 13: }
Line 14:
Line 15: public VmNetworkInterface getNetworkInterface() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNetworkCreatingManager.java
Line 43: for (NicWithLogicalNetworks edited :
nicsWithLogicalNetworks) {
Line 44: // can not use getId() because they have
different IDs - one is already created, one is not
Line 45: // yet
Line 46: boolean sameNic =
edited.getNetworkInterface().getName().equals(created.getName());
Line 47: boolean assignedNetworkChanged =
the logic looks a bit complex, maybe extract
"created.getNetworkName().equals(edited.getNetworkInterface().getNetworkName())"
to a variable as well - something like 'sameNetwork'
Line 48: !((created.getNetworkName() ==
null && edited.getNetworkInterface()
Line 49: .getNetworkName() == null)
||
Line 50: (created.getNetworkName() != null
&& created.getNetworkName()
Line 51:
.equals(edited.getNetworkInterface().getNetworkName())));
--
To view, visit http://gerrit.ovirt.org/15102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5b488236ba5a08fc9050ed13a6ed49802769da
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
