Alona Kaplan has posted comments on this change.
Change subject: webadmin, userportal: logical network editor
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
Line 97:
Line 98: @DefaultMessage("default [{0}]")
Line 99: String globalVncKeyboardLayoutCaption(String currentDefault);
Line 100:
Line 101: @DefaultMessage("VM has {0} Nics. Assign them to the Cluster''s
Virtual networks.")
Please change "Virtual" to "Logical".
Line 102: String assignNicsToNetworks(int numOfNics);
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/network/LogicalNetworkEditor.java
Line 30: private NicWithLogicalNetworks nicWithNetworks;
Line 31:
Line 32: private static final CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
Line 33:
Line 34: public LogicalNetworkEditor(String elementId) {
Why do you pass elementId param to the ctor if you don't use it?
Line 35: logicalNetworkEditor = new ListModelListBoxEditor<Network>(
Line 36: new NullSafeRenderer<Network>() {
Line 37: @Override
Line 38: public String renderNullSafe(Network network) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 1403: @Override
Line 1404: protected ConsoleContext getConsoleContext() {
Line 1405: return ConsoleContext.UP_EXTENDED;
Line 1406: }
Line 1407:
Please remove the empty lines.
Line 1408:
--
To view, visit http://gerrit.ovirt.org/15102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5b488236ba5a08fc9050ed13a6ed49802769da
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
