Alona Kaplan has posted comments on this change.
Change subject: webadmin, userportal: logical network editor
......................................................................
Patch Set 7: (1 inline comment)
Some verification comments-
- The "empty network" doesn't exist in the Vm->network interface new/edit
dialogs although it is on supported cluster version.
- I think that empty line in the network list is better than "No Network".
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/network/LogicalNetworksEditor.java
Line 76: networkEditor.setValue((NicWithLogicalNetworks) value);
Line 77: contentPanel.add(networkEditor);
Line 78: }
Line 79:
Line 80:
headerLabel.setText(messages.assignNicsToNetworks(values.size()));
I there are no nics on the vm this message shouldn't be shown.
Line 81: }
Line 82:
Line 83: public void flush() {
Line 84: // this flushes it
--
To view, visit http://gerrit.ovirt.org/15102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5b488236ba5a08fc9050ed13a6ed49802769da
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
