Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: logical network editor
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(4 inline comments)
Thanks Tomas.
@Alona - can you please take a look..
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NetworkFrontendActionAsyncCallbacks.java
Line 26: doNetworkOperation(returnValue,
Line 27: (List<NicWithLogicalNetworks>)
unitVmModel.getNicWithLogicalNetworks().getItems()
Line 28: );
Line 29: } else {
Line 30:
networkCreatingManager.getCallback().queryFaild(result.getState());
s/Faild/Failed
Line 31: }
Line 32: }
Line 33:
Line 34: protected abstract void doNetworkOperation(VdcReturnValueBase
returnValue, List<NicWithLogicalNetworks> nicWithLogicalNetworks);
Line 33:
Line 34: protected abstract void doNetworkOperation(VdcReturnValueBase
returnValue, List<NicWithLogicalNetworks> nicWithLogicalNetworks);
Line 35: }
Line 36:
Line 37: public static class
NetworkCreateOrUpdateFrontendActionAsyncCallback extends
BaseNetworkFrontendActionAsyncCallback {
formatter
Line 38:
Line 39: public NetworkCreateOrUpdateFrontendActionAsyncCallback(final
UnitVmModel unitVmModel,
Line 40: final
VmNetworkCreatingManager networkCreatingManager) {
Line 41: super(unitVmModel, networkCreatingManager);
Line 47: }
Line 48:
Line 49: }
Line 50:
Line 51: public static class NetworkCreateFrontendAsyncCallback extends
BaseNetworkFrontendActionAsyncCallback {
same
Line 52: public NetworkCreateFrontendAsyncCallback(final UnitVmModel
unitVmModel,
Line 53: final
VmNetworkCreatingManager networkCreatingManager) {
Line 54: super(unitVmModel, networkCreatingManager);
Line 55: }
Line 59: networkCreatingManager.createNetworks((Guid)
returnValue.getActionReturnValue(), nicWithLogicalNetworks);
Line 60: }
Line 61: }
Line 62:
Line 63: public static class NetworkUpdateFrontendAsyncCallback extends
BaseNetworkFrontendActionAsyncCallback {
same
Line 64:
Line 65: private final Guid idToUpdate;
Line 66:
Line 67: public NetworkUpdateFrontendAsyncCallback(final UnitVmModel
unitVmModel,
--
To view, visit http://gerrit.ovirt.org/15102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5b488236ba5a08fc9050ed13a6ed49802769da
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
