Yair Zaslavsky has posted comments on this change. Change subject: 5. core: Persist all async task placeholders ......................................................................
Patch Set 7: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java Line 328: command.setInternalExecution(runAsInternal); Line 329: command.setContext(context); Line 330: ExecutionHandler.prepareCommandForMonitoring(command, actionType, runAsInternal); Line 331: Line 332: command.checkCanDoAction(); Ravi, can we deal with Omer's previous comment (several days ago) about the seperation of checkCanDoAction from execteAction? Line 333: command.insertAsyncTaskPlaceHolders(); Line 334: returnValue = command.executeAction(); Line 335: returnValue.setCorrelationId(parameters.getCorrelationId()); Line 336: returnValue.setJobId(command.getJobId()); -- To view, visit http://gerrit.ovirt.org/15561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
