Ravi Nori has posted comments on this change.

Change subject: 6. core: Persist all async task placeholders
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1253:                             CommandBase<?> command =
Line 1254:                                     
Backend.getInstance().createAction(childCommandInfo.getFirst(),
Line 1255:                                             
childCommandInfo.getSecond());
Line 1256:                             command.insertAsyncTaskPlaceHolders();
Line 1257:                             
childCommandsMap.put(command.getCommandId(), command);
I think this should be

childCommandsMap.put(childCommandInfo.getKey(), command);
Line 1258:                         }
Line 1259:                         return null;
Line 1260:                     }
Line 1261:                 });


-- 
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to