Ravi Nori has posted comments on this change.

Change subject: 5. core: Persist all async task place holders
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 300:         getReturnValue().setDescription((tempVar != null) ? tempVar : 
getReturnValue().getDescription());
Line 301:         return _returnValue;
Line 302:     }
Line 303: 
Line 304:     private boolean actionAllowed = false;
This variable is set in checkCanDoAction and used in executeAction. So decided 
to move it to class level. Please let me know if you have any ideas
Line 305: 
Line 306:     protected void checkCanDoAction() {
Line 307:         actionAllowed = getReturnValue().getCanDoAction() || 
internalCanDoAction();
Line 308:     }


-- 
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to