Omer Frenkel has posted comments on this change.
Change subject: 6. core: Persist all async task placeholders
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
i wonder if we could use this in places where we want to run one command,
examine the result and then run the next one (for example, delete first disk,
if started successfully then continue, otherwise stop)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1262: return annotation != null && annotation.forceCompensation();
Line 1263: }
Line 1264:
Line 1265: /**
Line 1266: * This method is called before executeAction and after
checkCanDoAction
you said this comment should change
Line 1267: * to insert the async task place holders for the child commands.
Line 1268: */
Line 1269: protected void insertAsyncTaskPlaceHolders() {
Line 1270:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
