Yair Zaslavsky has posted comments on this change.

Change subject: core: Introducing Batch updates to DAOs
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 151:                 }
Line 152:                 rs2.close();
Line 153: 
Line 154:                 StringBuffer sqlCommand = new StringBuffer();
Line 155:                 sqlCommand.append("{call ").append(procSchemaFromDB)
I referred to that in the commit msg, SpringJDBC unfortunately does not 
"natively" support postgresql :(
Line 156:                         
.append(".").append(procNameFromDB).append("(")
Line 157:                         .append(params).append(")}");
Line 158: 
Line 159:                 procMetaData.setSqlCommand(sqlCommand.toString());


--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to