Liran Zelkha has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 56: * @param executions
Line 57: * A list of parameter maps
Line 58: * @return
Line 59: */
Line 60: public void runBatch(final String procName,
True
Line 61: final List<MapSqlParameterSource> executions)
Line 62: throws DataAccessException {
Line 63:
Line 64: template.execute(new ConnectionCallback<Object>() {
Line 74:
Line 75: for (MapSqlParameterSource execution : executions) {
Line 76: mapParams(stmt, execution,
Line 77: procMetaData.getParamatersMetaData());
Line 78: stmt.addBatch();
Yes. Unfortunately - this does not work. It only accept a list of Strings, and
doesn't call the stored procedures correctly.
Line 79: }
Line 80:
Line 81: try {
Line 82: stmt.executeBatch();
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
