Allon Mureinik has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 3: (2 inline comments)
I'm not sure I understand this patch - let's discuss?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 33: private DbEngineDialect dialect;
Line 34:
Line 35: private JdbcTemplate template;
Line 36:
Line 37: // private Map<String, List<MapSqlParameterSource>> batchSqls;
I assume this is a leftover - please remove
Line 38:
Line 39: public void setDbEngineDialect(DbEngineDialect dialect) {
Line 40: this.dialect = dialect;
Line 41: }
Line 83: } catch (SQLException e) {
Line 84: log.fatal("Can't execute batch: ", e);
Line 85: log.fatal("Can't execute batch. Next exception is:
",
Line 86: e.getNextException());
Line 87: throw e;
This is the only place inside this class you're logging - is that intentional?
Line 88: }
Line 89:
Line 90: stmt.close();
Line 91:
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
