Liran Zelkha has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 81: try {
Line 82: stmt.executeBatch();
Line 83: } catch (SQLException e) {
Line 84: log.fatal("Can't execute batch: ", e);
Line 85: log.fatal("Can't execute batch. Next exception is:
",
For simplicity - we need to check the nextException is not null...
Line 86: e.getNextException());
Line 87: throw e;
Line 88: }
Line 89:
Line 123: String colName = rs2.getString("COLUMN_NAME");
Line 124: int ordinal;
Line 125:
Line 126: try {
Line 127: ordinal = rs2.getInt("ORDINAL_POSITION");
This only works on upstream driver. Downstream driver will run into exception
(hence the internalCounter bit). This is wrong - and we should upgrade our
downstream driver.
Line 128: } catch (SQLException e) {
Line 129: // For some reason, some postgres drivers
don't provide
Line 130: // ORDINAL_POSITION
Line 131: ordinal = internalCounter;
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
