Yaniv Bronhaim has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: Relying on IP address can be tricky, host with address A in maintenance can get new dynamic address B when back to up. With this patch we won't allow adding new host with address A. This limits the user and wrong in some cases. The purpose of this patch is to avoid adding host that already registered, and as alonbl mentioned we do it as part of the deploy process by comparing UUIDs, and that's enough for this purpose. After understanding the use case of vds_interface table, I agree to avoid adding more unnecessary restrictions that can block the user from basic operations -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
