Yaniv Bronhaim has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: Of course we won't resolve each hostname in each adding operation, and that's exactly the reason why I've liked this patch. Apparently we already hold vds_interface table that keeps all the information we need about host's interfaces and addresses after adding a new host. With this information we can easily check if the ip address already assigned to one of the interfaces in DC, and we can prevent conflicts. The UUID helps to verify that we don't sign same host twice, and as I see it, those are two different issues that we need to handle. Doesn't it? The comment for this patch is wrong, we don't check if host was added twice, we check if the IP address of an host already configured for one of the interfaces. Maybe we've already have this verification that I miss.. but if not, I think we need it. -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
