Yaniv Bronhaim has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: The UUID verification works great when you deploy new host, and as you say much safer and better. But in this patch we check the IP as it is after resolving the hostname and verify that the ip is not already signed in DB, what can be if we passed the UUID validation. If it is, we have conflict that we need solve. My patch checked the vds hostname that, as you say, can be in many shapes, that's why we abandoned it. This quite different method to verify the IP. IMHO it can be useful in some cases. -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
