Alon Bar-Lev has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: I would prefer that you didn't submit this I think Yaniv submitted a patch for this in the past and we abandoned it. 1. Host name can take many forms... host.domain.domain.com, host.domain.domain, host.domain, host. 2. Host may have multiple addresses, ip1, ip2, ip3. 3. Host name may be resolved to multiple addresses host.domain -> ip1, ip2 or host.domain -> ip2, ip1. Doing any validation against host name is invalid. The current approach is much better and relay on vdsm id, the uuid generated during host-deploy either from random or from bios uuid. If this mechanism is not working, I will be glad to work with you to fix it. -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
