Moti Asayag has posted comments on this change.
Change subject: core: WIP: Support for device custom properties
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 523: -- Device Custom Properties
Line 524: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.0');
Line 525: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.1');
Line 526: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.2');
Line 527: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3');
Why there is a need for 2 configuration values ?
Line 528:
Line 529:
------------------------------------------------------------------------------------
Line 530: -- Update with override section
Line 531:
------------------------------------------------------------------------------------
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 4112: <value>true</value>
Line 4113: <value>true</value>
Line 4114: <value>false</value>
Line 4115: <value>alias</value>
Line 4116: <value></value>
you may use <null/> to provide a null value
Line 4117: </row>
Line 4118: </table>
Line 4119:
Line 4120: <table name="job">
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 659
Line 660
Line 661
Line 662
Line 663
this change isn't related to the patch.
probably caused by IDE configuration to remove redundant casting.
--
To view, visit http://gerrit.ovirt.org/14309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ed453706ac75cdc4356cc2d60913d8958c89ed
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
