Martin Peřina has posted comments on this change. Change subject: core: WIP: Support for device custom properties ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 522: Line 523: -- Device Custom Properties Line 524: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', '3.0'); Line 525: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', '3.1'); Line 526: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', '3.2'); No problem, I will add the line. But now I really don't understand the concept of @DefaultValueAttribute ... Line 527: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3'); Line 528: Line 529: ------------------------------------------------------------------------------------ Line 530: -- Update with override section -- To view, visit http://gerrit.ovirt.org/14309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67ed453706ac75cdc4356cc2d60913d8958c89ed Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches