Yair Zaslavsky has posted comments on this change. Change subject: core: DB support for device custom properties ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/vm_device_sp.sql Line 12: v_is_managed boolean, Line 13: v_is_plugged boolean, Line 14: v_is_readonly boolean, Line 15: v_alias varchar(255), Line 16: v_custom_properties varchar(4000)) Hmm, I think we should have had it as text in vm_static. Let's go for text. Line 17: RETURNS VOID Line 18: AS $procedure$ Line 19: BEGIN Line 20: INSERT INTO vm_device( -- To view, visit http://gerrit.ovirt.org/14309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67ed453706ac75cdc4356cc2d60913d8958c89ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
