Yair Zaslavsky has posted comments on this change.

Change subject: core: DB support for device custom properties
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/03_03_0120_add_device_custom_prop.sql
Line 1: select fn_db_add_column('vm_device', 'custom_properties', 'TEXT');
Line 2: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', 
'3.0');
add_config_value should be performed at config_0000.sql
Sorry for not mentioning it before.
Line 3: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', 
'3.1');
Line 4: select fn_db_add_config_value('SupportCustomDeviceProperties', 'false', 
'3.2');


--
To view, visit http://gerrit.ovirt.org/14309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ed453706ac75cdc4356cc2d60913d8958c89ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to