Yair Zaslavsky has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: Martin - I understand your points, but - If we add for example LdapProviderType (let's say - OpenLdap as was suggested by another patch in the community) - you will still have to include it in the shell script - that is, provide details about it at the script. In general, the current behavior is "pass through" at shell side, and parsing logic at java side. What I was thinking is that maybe we can have "parsing logic" at script Side. at engine you will receive data , let's say in form of java -cp ..... MyUtility param1=value1 param2=value2 and so on. Yes, you don't "know" what is the type of the parameters , but then parsing at java side will be only about converting the value based to types (let's say you'll hold the type information in some data structure). I think this can reduce the amount of new code being introduced What do you think? -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
