Martin Peřina has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: (2 inline comments) Parser in org.ovirt.engine.core.utils.cli has been developed to solve these issues: 1) Parsing of POSIX and GNU log command line arguments in standards compliant way 2) Having an API to easily add command line argument parsing to other Java utilities in oVirt (and replace current buggy and non standards complying implementation) 3) Printing command help from defined options instead of having them hardcoded in shell script And now for Python or Shell implementation: I think it's bad idea. Despite the fact, that arguments will be defined on two places, you will have add code to convert map array values to specified param and convert from string to required type. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentParser.java Line 4: Line 5: /** Line 6: * Represents an argument parser Line 7: * Line 8: * @author [email protected] No, problem, I will remove them. Line 9: */ Line 10: public interface ArgumentParser { Line 11: /** Line 12: * Adds specified option and its requirements to the parser .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/cli/LdapProviderParameterValue.java Line 6: * LDAP provider parameter value Line 7: * Line 8: * @author [email protected] Line 9: */ Line 10: public enum LdapProviderParameterValue { I didn't want to extend LdapProviderType, because these strings is used only for command line parsing, so with this enum I have decorated it to be useful for command line parsing. Line 11: /** Line 12: * Microsoft Active Directory Line 13: */ Line 14: AD (LdapProviderType.activeDirectory), -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
