Martin Peřina has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 2: Alon, your shell script parsing sample doesn't solve these issues: 1) parameter requirements (engine-manage-domains is even more complicated, because each command have different required parameters) 2) Validity of parameter value 3) Hard coded help in shell (if add new parameter you have to add it in Java and in shell also) Even with this shell script you will need a lot of Java code to cover what's needed in engine-manage-domains. -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
