Roy Golan has posted comments on this change. Change subject: core: use local TX in AddVm flow ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java Line 51: getTaskIdList().addAll(returnValueFromAddVm.getInternalTaskIdList()); Line 52: AddVmToPoolParameters tempVar3 = new AddVmToPoolParameters(getParameters().getPoolId(), Line 53: vmStatic.getId()); Line 54: tempVar3.setShouldBeLogged(false); Line 55: setSucceeded(Backend.getInstance().runInternalAction(VdcActionType.AddVmToPool, tempVar3).getSucceeded()); the deleteVmstatic SP that is called from EndWithFailure will remove any permissions related to it. this is off course due to the fact permissions table can't relate a foreign key for MANY tables to Object_id Line 56: addVmPermission(); Line 57: } Line 58: } -- To view, visit http://gerrit.ovirt.org/13805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
