Roy Golan has posted comments on this change.
Change subject: core: use local TX in AddVm flow
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 178: new
GetImageInfoVDSCommandParameters(storagePoolId, storageDomainId, imageGroupId,
Line 179:
getImage().getImageId())).getReturnValue();
Line 180:
Line 181: if (image.getImageStatus() != ImageStatus.OK) {
Line 182: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
check image validity is the first update in this flow.
tihs was also verified.
However putting this in Required is indeed safer here
Line 183: @Override
Line 184: public Void runInTransaction() {
Line 185:
getCompensationContext().snapshotEntityStatus(diskImage,
diskImage.getImageStatus());
Line 186:
diskImage.setImageStatus(image.getImageStatus());
--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
