Maor Lipchuk has posted comments on this change.
Change subject: core: use local TX in AddVm flow
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
Line 31: tempVar.setSessionId(getParameters().getSessionId());
Line 32: tempVar.setDontAttachToDefaultTag(true);
Line 33: returnValueFromAddVm =
Line 34:
Backend.getInstance().runInternalAction(VdcActionType.AddVmFromScratch,
Line 35: tempVar,
That could work also, but in that case, we should check the return value and
set the succeeded boolean with false and return immidietly at each internal
action.
Line 36:
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
Line 37: } else {
Line 38: VmManagementParametersBase tempVar2 = new
VmManagementParametersBase(vmStatic);
Line 39: tempVar2.setSessionId(getParameters().getSessionId());
Line 50: if (vmAddedSuccessfully) {
Line 51:
getTaskIdList().addAll(returnValueFromAddVm.getInternalTaskIdList());
Line 52: AddVmToPoolParameters tempVar3 = new
AddVmToPoolParameters(getParameters().getPoolId(),
Line 53: vmStatic.getId());
Line 54: tempVar3.setShouldBeLogged(false);
I tend to agree.
Line 55:
setSucceeded(Backend.getInstance().runInternalAction(VdcActionType.AddVmToPool,
tempVar3).getSucceeded());
Line 56: addVmPermission();
Line 57: }
Line 58: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 499: copyVmDevices();
Line 500: addDiskPermissions(newDiskImages);
Line 501: addVmPayload();
Line 502: updateSmartCardDevices();
Line 503: setActionReturnValue(getVm().getId());
That can work also, just need to verify that on failure the devices are being
deleted or updated accordingly.
Line 504: setSucceeded(true);
Line 505: return null;
Line 506: }
Line 507: });
--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
