Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Select english when browser is other locale
......................................................................


Patch Set 4:

Some notes on "en" locale & default constant/message handling:
* "en" locale has no properties files, so it (intentionally) falls through to 
use default (English) constants/messages
* default (English) constants/messages are currently specified in Java 
interfaces via annotations, e.g. @DefaultStringValue & @DefaultMessage
* I still believe that "default" locale is useful for providing default 
(English) fallback when the given constant/message isn't specified 
locale-specific properties file

--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to