Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
......................................................................
Patch Set 3: (1 inline comment)
Maybe we could include one more change in this patch: instead of hard-coded
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
Line 83:
Line 84: localeBox.addChangeHandler(new ChangeHandler() {
Line 85: @Override
Line 86: public void onChange(ChangeEvent event) {
Line 87: String localeString = "?locale=" +
localeBox.getValue(localeBox.getSelectedIndex()); //$NON-NLS-1$
Maybe we should use LocaleInfo.getLocaleQueryParam() instead of hard-coded
"locale" string.
Line 88: Window.open(FrontendUrlUtils.getCurrentPageURL() +
localeString, "_self", ""); //$NON-NLS-1$ //$NON-NLS-2$
Line 89: }
Line 90: });
Line 91: }
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
