Tomas Jelinek has posted comments on this change.
Change subject: ui: use real OS names
......................................................................
Patch Set 6: Looks good to me, approved
(2 inline comments)
just two tiny formatting notes, otherwise looks ok
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
Line 66: @Path("SelectedItem.Description")
Line 67: @WithElementId("description")
Line 68: Label vmDescription;
Line 69:
Line 70: @UiField()
no need for empty parentheses
Line 71: @Path("SelectedItem.OsType")
Line 72: @WithElementId("os")
Line 73: EnumLabel<VmOsType> operatingSystem;
Line 74:
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
Line 4: xmlns:g="urn:import:com.google.gwt.user.client.ui"
Line 5: xmlns:e="urn:import:org.ovirt.engine.ui.userportal.widget.basic"
Line 6: xmlns:r="urn:import:org.ovirt.engine.ui.userportal.widget"
Line 7: xmlns:l="urn:import:org.ovirt.engine.ui.common.widget.label">
please format it the same way as the rest of the declarations
Line 8:
Line 9:
Line 10: <ui:with field='resources'
Line 11:
type='org.ovirt.engine.ui.userportal.ApplicationResources' />
--
To view, visit http://gerrit.ovirt.org/12475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
