Roy Golan has uploaded a new change for review. Change subject: ui: use real OS names ......................................................................
ui: use real OS names added constant file based on VMOstype as its key and a translator from VMOstype to a FQN for it. so now the real os name could be fetch using OSNamesTranslator.translate(VMOsType.RHEL3) Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895609 Signed-off-by: Roy Golan <rgo...@redhat.com> --- A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesConstants.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesTranslator.java 2 files changed, 94 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/12475/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesConstants.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesConstants.java new file mode 100644 index 0000000..7a85701 --- /dev/null +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesConstants.java @@ -0,0 +1,73 @@ +package org.ovirt.engine.ui.frontend; + +import com.google.gwt.i18n.client.ConstantsWithLookup; + +public interface OSNamesConstants extends ConstantsWithLookup { + + @DefaultStringValue("Other") + String Other(); + + @DefaultStringValue("Other Linux") + String OtherLinux(); + + @DefaultStringValue("Red Hat Enterprise Linux 3") + String RHEL3(); + + @DefaultStringValue("Red Hat Enterprise Linux 3 64 bit") + String RHEL3x64(); + + @DefaultStringValue("Red Hat Enterprise Linux 4") + String RHEL4(); + + @DefaultStringValue("Red Hat Enterprise Linux 4 64 bit") + String RHEL4x64(); + + @DefaultStringValue("Red Hat Enterprise Linux 5") + String RHEL5(); + + @DefaultStringValue("Red Hat Enterprise Linux 5 64 bit") + String RHEL5x64(); + + @DefaultStringValue("Red Hat Enterprise Linux 6") + String RHEL6(); + + @DefaultStringValue("Red Hat Enterprise Linux 6 64 bit") + String RHEL6x64(); + + @DefaultStringValue("Unassigned") + String Unassigned(); + + @DefaultStringValue("Microsoft Windows Server 2003") + String Windows2003(); + + @DefaultStringValue("Microsoft Windows Server 2003 64 bit") + String Windows2003x64(); + + @DefaultStringValue("Microsoft Windows Server 2008") + String Windows2008(); + + @DefaultStringValue("Microsoft Windows Server 2008 R2 64 bit") + String Windows2008R2x64(); + + @DefaultStringValue("Microsoft Windows Server 2008 64 bit") + String Windows2008x64(); + + @DefaultStringValue("Microsoft Windows Server 2012") + String Windows2012x64(); + + @DefaultStringValue("Microsoft Windows 7") + String Windows7(); + + @DefaultStringValue("Microsoft Windows 7 64 bit") + String Windows7x64(); + + @DefaultStringValue("Microsoft Windows 8") + String Windows8(); + + @DefaultStringValue("Microsoft Windows 8 64 bit") + String Windows8x64(); + + @DefaultStringValue("Microsoft Windows XP") + String WindowsXP(); + +} diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesTranslator.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesTranslator.java new file mode 100644 index 0000000..16d3a5d --- /dev/null +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesTranslator.java @@ -0,0 +1,21 @@ +package org.ovirt.engine.ui.frontend; + +import java.util.MissingResourceException; + +import org.ovirt.engine.core.common.businessentities.VmOsType; + +import com.google.gwt.core.client.GWT; + +public class OSNamesTranslator { + + private static final OSNamesConstants osNamesConstants = GWT.create(OSNamesConstants.class); + + public String translate(VmOsType os) { + try { + return osNamesConstants.getString(os.name()); //$NON-NLS-1$ + } catch (MissingResourceException e) { + return os.name(); + } + } + +} -- To view, visit http://gerrit.ovirt.org/12475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
