Tomas Jelinek has posted comments on this change.
Change subject: ui: use real OS names
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
Line 101: Style style;
Line 102:
Line 103: @Inject
Line 104: public MainTabBasicDetailsView(ApplicationResources resources) {
Line 105: operatingSystem = new EnumLabel<VmOsType>();
In this case you don't need to create the instance by yourself - remove the
(provided = true) from the declaration, remove this operatingSystem = new
EnumLabel<VmOsType>(); completely and than MainTabBasicDetailsView.ui.xml
declare a new namespace like:
xmlns:l="urn:import:org.ovirt.engine.ui.common.widget.label"
and than you can replace <g:ValueLabel ui:field="operatingSystem"... by
<l:EnumLabel ui:field="operatingSystem" ...
Line 106: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 107: Driver.driver.initialize(this);
Line 108: ViewIdHandler.idHandler.generateAndSetIds(this);
Line 109: }
--
To view, visit http://gerrit.ovirt.org/12475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
