Daniel Erez has posted comments on this change.
Change subject: ui: use real OS names
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
Line 109: private OSNamesTranslator osNamesTranslator = new
OSNamesTranslator();;
Line 110:
Line 111: @Override
Line 112: public String render(VmOsType object) {
Line 113: return osNamesTranslator.translate(object);
please modify Enums.properties/Enums.java instead
(since the OSNamesTranslator is not localized and VMOstype should probably be
localized later on)
Line 114: }
Line 115: });
Line 116:
Line 117: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
--
To view, visit http://gerrit.ovirt.org/12475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
