Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 100: }
Line 101:
Line 102: private void fetchAdvancedDetails(String volumeName) {
Line 103: VDSReturnValue returnValue = executeCommand(volumeName);
Line 104:
getQueryReturnValue().setReturnValue(returnValue.getReturnValue());
I think it is better to set the return value at the topmost level i.e. in
executeQueryCommand()
So I would suggest to remove this method, and rename executeCommand() to
fetchAdvancedDetails(). And the code in executeQueryCommand() can look like:
@Override
protected void executeQueryCommand() {
String volumeName = getParameters().getVolumeName();
if (StringUtils.isNotEmpty(volumeName)) {
getQueryReturnValue().setReturnValue(fetchAdvancedDetails(volumeName));
} else {
getQueryReturnValue().setReturnValue(getServiceInfo());
}
}
This also means that the methods getServiceInfo() and fetchAdvancedDetails()
will return GlusterVolumeAdvancedDetails.
Line 105: }
Line 106:
Line 107: private VDSReturnValue executeCommand(String volumeName) {
Line 108: VDSReturnValue returnValue =
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
