Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 48: * and another with replicate volume name, finally combine
the service details.
Line 49: */
Line 50:
Line 51: if (getParameters().isDetailRequired() ||
StringUtils.isNotEmpty(volumeName)) {
Line 52: executeAndSetReturnValue(volumeName);
Don't you need to return from here?
Line 53: }
Line 54:
Line 55: VDSReturnValue nfsReturnValue = null;
Line 56: VDSReturnValue replicateReturnValue = null;
Line 56: VDSReturnValue replicateReturnValue = null;
Line 57: // Get Nfs + Replicated/Distributed Replicate volume.
Line 58: GlusterVolumeEntity nfsReplicateVolume =
getNfsReplicateVolume(getParameters().getClusterId());
Line 59: if (nfsReplicateVolume != null) {
Line 60: executeAndSetReturnValue(nfsReplicateVolume.getName());
Same here.
Line 61: }
Line 62:
Line 63: // Get Nfs enabled volume
Line 64: GlusterVolumeEntity nfsVolume =
getNfsVolume(getParameters().getClusterId());
Line 97:
Line 98: private void executeAndSetReturnValue(String volumeName) {
Line 99: VDSReturnValue returnValue = executeCommand(volumeName);
Line 100:
getQueryReturnValue().setReturnValue(returnValue.getReturnValue());
Line 101: return;
this "return;" statement is of no use.
Line 102: }
Line 103:
Line 104: private VDSReturnValue executeCommand(String volumeName) {
Line 105: VDSReturnValue returnValue =
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
