Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 9: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 45: * 2. If not found then fetch the nfs volume name and then
fetch
Line 46: * REPLICATE/DISTRIBUTED_REPLICATE volume name
Line 47: * 3. The VDS query will be called twice, one with nfs volume
name
Line 48: * and another with replicate volume name, finally combine
the service details.
Line 49: */
I guess this comment is more appropriate after the if block below.
Line 50:
Line 51: if (getParameters().isDetailRequired() &&
StringUtils.isNotEmpty(volumeName)) {
Line 52: executeAndSetReturnValue(volumeName);
Line 53: return;
Line 47: * 3. The VDS query will be called twice, one with nfs volume
name
Line 48: * and another with replicate volume name, finally combine
the service details.
Line 49: */
Line 50:
Line 51: if (getParameters().isDetailRequired() &&
StringUtils.isNotEmpty(volumeName)) {
Even if caller sets isDetailsRequired() = false, I think we should fetch
service details of the given volume and return it. So I think this if condition
need not check for getParameters().isDetailRequired()
Line 52: executeAndSetReturnValue(volumeName);
Line 53: return;
Line 54: }
Line 55:
Line 52: executeAndSetReturnValue(volumeName);
Line 53: return;
Line 54: }
Line 55:
Line 56: VDSReturnValue nfsReturnValue = null;
It will be more readable if this whole piece of code is extracted out into a
method - something like "getServiceInfo()"
Line 57: VDSReturnValue replicateReturnValue = null;
Line 58: // Get Nfs + Replicated/Distributed Replicate volume.
Line 59: GlusterVolumeEntity nfsReplicateVolume =
getNfsReplicateVolume(getParameters().getClusterId());
Line 60: if (nfsReplicateVolume != null) {
Line 96:
getQueryReturnValue().setReturnValue(nfsReturnValue.getReturnValue());
Line 97: }
Line 98: }
Line 99:
Line 100: private void executeAndSetReturnValue(String volumeName) {
how about calling this "fetchAdvancedDetails()" ?
Line 101: VDSReturnValue returnValue = executeCommand(volumeName);
Line 102:
getQueryReturnValue().setReturnValue(returnValue.getReturnValue());
Line 103: }
Line 104:
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
