Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 23: private static final String OPTION_KEY_NFS_DISABLE = "nfs.disable";
Line 24: private static final String OPTION_VALUE_OFF = "off";
Line 25: private static final List<GlusterVolumeType> volumeTypes =
Line 26: new ArrayList<GlusterVolumeType>(Arrays.asList(new
GlusterVolumeType[] {
Line 27: GlusterVolumeType.REPLICATE,
GlusterVolumeType.DISTRIBUTED_REPLICATE }));
Arrays.asList() returns a List anyway. Why wrap it inside another ArrayList?
Line 28:
Line 29: public GetGlusterVolumeAdvancedDetailsQuery(P params) {
Line 30: super(params);
Line 31: }
Line 49: * 3. The VDS query will be called twice, one with nfs volume
name
Line 50: * and another with replicate volume name, finally combine
the service details.
Line 51: */
Line 52: if (!getParameters().isDetailRequired() &&
StringUtils.isEmpty(volumeName)) {
Line 53: VDSReturnValue nfsReturnValue = null;
Now, everything that happens here is getting overridden by last two lines of
the method!
Line 54: VDSReturnValue replicateReturnValue = null;
Line 55: GlusterVolumeEntity nfsVolume;
Line 56: GlusterVolumeEntity replicateVolume;
Line 57: // Get Nfs + Replicated/Distributed Replicate volume.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java
Line 1: package org.ovirt.engine.core.bll.gluster;
Line 2:
Line 3: import
org.ovirt.engine.core.common.queries.gluster.GlusterVolumeQueriesParameters;
This change should be a separate patch. It has nothing to do with this patch.
Line 4: import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
Line 5: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
Line 6: import
org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeProfileInfoVDSParameters;
Line 7:
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
