Alex Lourie has posted comments on this change.
Change subject: packaging: Application Mode option in installer
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File packaging/fedora/setup/basedefs.py
Line 62: DIR_ENGINE_CONFIG_CONF="/etc/ovirt-engine/engine-config/"
Line 63: DIR_OVIRT_PKI="/etc/pki/ovirt-engine"
Line 64:
Line 65: DIR_YUM_CACHE = "/var/cache/yum"
Line 66: DIR_PKGS_INSTALL = "/usr/share"
Already defined as DIR_USR_SHARE
Line 67:
Line 68: FILE_INSTALLER_LOG="engine-setup.log"
Line 69: FILE_KRB_CONF="%s/deployments/configuration/krb5.conf" % DIR_ENGINE
Line 70: FILE_CA_CRT_SRC="%s/ca.pem"%(DIR_OVIRT_PKI)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 454: "NEED_CONFIRM" : False,
Line 455: "CONDITION" : True} ]
Line 456: }
Line 457:
Line 458: if basedefs.SHOW_APPLICATION_MODE_IN_SETUP:
I would just always have this as a parameter present in the setup. There's no
need to hide it from the user.
Line 459: conf_params["ALL_PARAMS"].append({"CMD_OPTION" :
"application-mode",
Line 460: "USAGE" :
output_messages.INFO_CONF_PARAMS_APPLICATION_MODE_USAGE,
Line 461: "PROMPT" :
output_messages.INFO_CONF_PARAMS_APPLICATION_MODE_PROMPT,
Line 462: "OPTION_LIST" :
["virt","gluster", "both"],
....................................................
File packaging/fedora/setup/output_messages.py
Line 141: INFO_CONF_PARAMS_DB_PASSWD_USAGE="Password for the local database
administrator"
Line 142: INFO_CONF_PARAMS_DB_PASSWD_PROMPT="Enter a password for a local %s DB
admin user (%s)" % (basedefs.APP_NAME, basedefs.DB_USER)
Line 143: INFO_CONF_PARAMS_PASSWD_CONFIRM_PROMPT="Confirm password"
Line 144: INFO_CONF_PARAMS_APPLICATION_MODE_USAGE="Application Mode"
Line 145: INFO_CONF_PARAMS_APPLICATION_MODE_PROMPT="Select the feature you
would like to enable in UI"
I would still ask for a more elaborate explanation.
Without knowing too much about the subject, user will probably not understand
what is he asked about.
Is it possible to explain what application mode is in 1-2 lines above this
prompt?
Line 146:
Line 147: #Remote DB interaction
Line 148: INFO_CONF_PARAMS_REMOTE_DB_USAGE="Select local or remote DB server"
Line 149: INFO_CONF_PARAMS_REMOTE_DB_PROMPT="Enter DB type for installation"
--
To view, visit http://gerrit.ovirt.org/9991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
