Shireesh Anjal has posted comments on this change. Change subject: packaging: Application Mode option in installer ......................................................................
Patch Set 5: Hi Alex, I believe you are referring to CONST_DEFAULT_APPLICATION_MODE. It is set to true in the source, which means it will always be shown when user is installing oVirt. I don't think user is expected to change it's value, or even know about it. The variable helps in easily disabling this question from downstream distributions e.g. RHEV-M. In case of RHEV-M, it would always want to install the engine in virt+gluster (both) mode, and hence will not ask this question to the user. So the idea is to make such a (downstream) change in behavior as simple as possible. Of course, if you have a better way of doing this, do suggest the same. Thanks, Shireesh -- To view, visit http://gerrit.ovirt.org/9991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
