Juan Hernandez has posted comments on this change.

Change subject: packaging: Application Mode option in installer
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File packaging/fedora/setup/engine-setup.py
Line 979:                                
output_messages.ERR_DB_SET_SERVICE_TYPE)
Line 980: 
Line 981:     # No change with respect to default application mode, No DB 
update required
Line 982:     if controller.CONF["APPLICATION_MODE"].upper() == "BOTH":
Line 983:         return
Ok, understood, thanks for explaining.

The upgrade scripts can't be modified, as we save a MD5 digest of their 
contents.
Line 984: 
Line 985:     applicationMode = 
controller.CONF["APPLICATION_MODE_ENUM"].parse(str.upper(controller.CONF["APPLICATION_MODE"]))
Line 986: 
Line 987:     sqlQuery = "select fn_db_update_config_value('ApplicationMode', 
'%s', 'general')" % applicationMode


--
To view, visit http://gerrit.ovirt.org/9991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to