Alex Lourie has posted comments on this change. Change subject: packaging: Application Mode option in installer ......................................................................
Patch Set 5: I am concerned with the implementation of the feature from the UX point of view. What would be the reason to hide the option from the user, and more, doing that with the constant in the basedefs? If this is a viable option, we need always show it. For example, we can precede this with the question, such as explaining what the application mode is and then "would you like to configure an application mode?", and if answered yes, continue to parameters questions. I highly doubt that most of our users would ever think of touching basedefs file (which is a "production" code) to alter the setup. I would rather believe that this should be set in an answer file during automated installation, similar to configuring or not configuring the firewall rules. -- To view, visit http://gerrit.ovirt.org/9991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
