Allon Mureinik has posted comments on this change. Change subject: core: remove expensive use of ObjectDescriptor.toString ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) Giving -1 to stop accidental merge in case I was right and Common.gwt.xml contains a mistake. @Roy - if it's OK, just answer, and I'll remove the -1. Except for this concern, the patch is +2 IMHO. .................................................... File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml Line 280: Line 281: <!-- Backend V<include name="searchbackend/SqlInjectionChecker.java" /> Line 282: <include name="searchbackend/PostgresSqlInjectionChecker.java" />alidation Line 283: framework --> Line 284: <include name="common/utils/EnumUtils.java" /> You sure about removing the reference to IObjectDescriptorContainer here? because it still exists in the code base (perhaps it too should be removed? it seems a bit useless to me) Line 285: <include name="common/validation/annotation/HostnameOrIp.java" /> Line 286: <include name="common/validation/group/**" /> Line 287: Line 288: <!-- Gluster --> -- To view, visit http://gerrit.ovirt.org/10356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bb51579a9af1f76248cb1152e29ad7cb82d8a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
