Alissa Bonas has posted comments on this change.

Change subject: core: remove expensive use of ObjectDescriptor.toString
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StatusReturnForXmlRpc.java
Line 15:     }
Line 16: 
Line 17:     @Override
Line 18:     public String toString() {
Line 19:         return "StatusReturnForXmlRpc [mStatus=" + mStatus + "]";
what about getClass().getSimpleName here like in other places?
Line 20:     }
Line 21: 


--
To view, visit http://gerrit.ovirt.org/10356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0bb51579a9af1f76248cb1152e29ad7cb82d8a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to