Alex Lourie has posted comments on this change. Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 1030: # Disconnect active connections Line 1031: # First, check psql version, as this would work differently for 9.2 Line 1032: logging.info("Checking PostgreSQL version") Line 1033: pid = "procpid" Line 1034: if getRpmVersion("postgresql").startswith("9.2"): Done with direct sql query with the DB Line 1035: logging.info("Detected PostgreSQL version 9.2") Line 1036: pid = "pid" Line 1037: Line 1038: logging.info("Disconnect active connections from DB '%s'" % dbName) .................................................... File packaging/fedora/setup/output_messages.py Line 225: ERR_YUM_LOCK="Internal Error: Can't edit versionlock " Line 226: ERR_RPM_QUERY="Internal Error: Can't query rpm versions" Line 227: Line 228: #_DB Errors Line 229: ERR_PSQL = "Error: failed to find PostgreSQL version." Done Line 230: ERR_DB_CREATE_FAILED="Database creation failed" Line 231: ERR_DB_UPGRADE_FAILED="Database upgrade failed. Previous database has been restored" Line 232: ERR_DB_BACKUP="Database backup failed" Line 233: ERR_DB_RESTORE="Database restore failed" -- To view, visit http://gerrit.ovirt.org/10389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches