Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1030: # Disconnect active connections
Line 1031: # First, check psql version, as this would work differently for
9.2
Line 1032: logging.info("Checking PostgreSQL version")
Line 1033: pid = "procpid"
Line 1034: if getRpmVersion("postgresql").startswith("9.2"):
This is not wise!
You should check using the tools, as server may be in different host.
Using RPM is allowed only for stuff that cannot be done otherwise.
Line 1035: logging.info("Detected PostgreSQL version 9.2")
Line 1036: pid = "pid"
Line 1037:
Line 1038: logging.info("Disconnect active connections from DB '%s'" %
dbName)
--
To view, visit http://gerrit.ovirt.org/10389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
