Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1042: "-d", dbName,
Line 1043: "-c", version_query,
Line 1044: ]
Line 1045: out, rc = execCmd(cmdList=cmd, failOnError=True,
msg=output_messages.ERR_POSTGRESQL)
Line 1046: pattern = ".*(\d\.\d)\..*"
I suggest something like:
\SPostgreSQL\S([\d.]+)\S.*
Line 1047: version = re.match(pattern, out).group(1)
Line 1048: if version.startswith("9.2"):
Line 1049: logging.info("Detected PostgreSQL version 9.2")
Line 1050: pid = "pid"
--
To view, visit http://gerrit.ovirt.org/10389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
